Conversation
|
Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration ( |
bdraco
approved these changes
May 11, 2020
Member
There was a problem hiding this comment.
Without sharing
python3 24892 root 42u IPv4 88999451 0t0 UDP *:mdns
python3 24892 root 43u IPv4 88999452 0t0 UDP *:mdns
python3 24892 root 81u IPv4 89000658 0t0 UDP *:mdns
python3 24892 root 89u IPv4 89001374 0t0 UDP *:mdns
python3 24892 root 90u IPv4 89000659 0t0 UDP *:mdns
python3 24892 root 91u IPv4 89001375 0t0 UDP *:mdns
python3 24892 root 92u IPv4 89001376 0t0 UDP *:mdns
With sharing
python3 2411 root 42u IPv4 89066539 0t0 UDP *:mdns
python3 2411 root 43u IPv4 89066540 0t0 UDP *:mdns
Still need to figure out where the 2nd one is coming from but now there is a path forward once its found.
Very nice!
Member
|
Unignored everything, verified zeroconf discovery still hapening. |
Member
|
Will modify homekit in the morning to leverage this (well later today now). |
Member
Author
|
Cast is the other one probably. |
This was referenced May 11, 2020
This was referenced May 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Zeroconf instances are expensive. @bdraco noticed that each Homekit instance has their own instance, and on big networks it's eating CPU.
This new approach allows the zeroconf instance to be shared.
For integrations to use it,
zeroconfneeds to be in eitherdependenciesorafter_dependenciesso that a user can configure the used interface.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: