Skip to content

Fix roomba bin full binary sensor#35443

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
shenxn:fix-roomba-binary-sensor
May 10, 2020
Merged

Fix roomba bin full binary sensor#35443
MartinHjelmare merged 1 commit intohome-assistant:devfrom
shenxn:fix-roomba-binary-sensor

Conversation

@shenxn
Copy link
Copy Markdown
Contributor

@shenxn shenxn commented May 10, 2020

Proposed change

Fix the problem that roomba bin full binary sensor gives True / False states instead of on / off.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @pschmitt, @cyr-ius, mind taking a look at this pull request as its been labeled with a integration (roomba) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 8050d85 into home-assistant:dev May 10, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented May 10, 2020

Should we tag this for a patch release?

There will probably not be another patch release before the beta, but you never know.

@shenxn shenxn deleted the fix-roomba-binary-sensor branch May 11, 2020 20:28
@shenxn shenxn mentioned this pull request May 11, 2020
20 tasks
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roomba bin_full states

3 participants