Skip to content

async_get_url -> get_url#35382

Merged
frenck merged 2 commits into
devfrom
frenck-2020-0487
May 8, 2020
Merged

async_get_url -> get_url#35382
frenck merged 2 commits into
devfrom
frenck-2020-0487

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 8, 2020

Proposed change

Processes a review comment by @MartinHjelmare about the new get_url helper.

#35224 (review)

I will update the developers' documentation and development blog in a second. Done.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread homeassistant/components/tts/__init__.py Outdated
@frenck frenck merged commit e3e3a11 into dev May 8, 2020
@frenck frenck deleted the frenck-2020-0487 branch May 8, 2020 19:53
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants