Skip to content

Detect use of deprecated base_url#35353

Merged
pvizeli merged 4 commits into
devfrom
frenck-2020-0479
May 8, 2020
Merged

Detect use of deprecated base_url#35353
pvizeli merged 4 commits into
devfrom
frenck-2020-0479

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 8, 2020

Proposed change

Followup of #35224.

This PR adds detection of accessing the base_url property and puts out a warning, similar to how I/O detection works.

Our own codebase has been migrated already as part of #35224, this PR handles the tests for our codebase.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@frenck frenck changed the title Frenck 2020 0479 Detect use of deprecated base_url May 8, 2020
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 8, 2020

Test failure is unrelated #35356

@frenck frenck force-pushed the frenck-2020-0479 branch from 012498e to 04db5c5 Compare May 8, 2020 09:41
@frenck
Copy link
Copy Markdown
Member Author

frenck commented May 8, 2020

Rebased onto dev to address the build issue.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pvizeli pvizeli merged commit e56dd8e into dev May 8, 2020
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2020-0479 branch May 8, 2020 15:52
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants