Skip to content

Fix broken CI#35314

Merged
balloob merged 1 commit intodevfrom
fix-broken-ci
May 7, 2020
Merged

Fix broken CI#35314
balloob merged 1 commit intodevfrom
fix-broken-ci

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 7, 2020

Breaking change

Proposed change

In #35010 we introduced an extra way of catching exceptions raised during tests. This PR was branched off an older dev, and so a new test was added in the meanwhile that started breaking CI once we started catching the exceptions. In this case it was a unifi test. Added it to the ignore for now.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (unifi) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit e3ca87b into dev May 7, 2020
@balloob balloob deleted the fix-broken-ci branch May 7, 2020 01:40
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants