Plex discovery on demand#35303
Conversation
probot-home-assistant
Bot
added
integration: plex
new-feature
small-pr
| for server_data in gdm.entries: | ||
| await hass.config_entries.flow.async_init( | ||
| DOMAIN, | ||
| context={"source": config_entries.SOURCE_DISCOVERY}, |
There was a problem hiding this comment.
We should use another source. This source is already reserved for the discovery integration.
There was a problem hiding this comment.
Should I create a new one? Any suggestions in mind? Maybe "discovery requested" or "onboarding"?
There was a problem hiding this comment.
integration_discovery maybe? Or self discovery
jjlawren
force-pushed
the
plex_discovery_on_demand
branch
from
fbc4884 to
8b726b5
Compare
| } | ||
|
|
||
|
|
||
| async def async_discover(hass): |
There was a problem hiding this comment.
Nothing yet (besides the tests). The plan discussed is to offer integration-handled discovery as part of onboarding.
There was a problem hiding this comment.
Is there an architecture issue where this is described?
There was a problem hiding this comment.
Actually, this is already described pretty well in home-assistant/architecture#172.
There was a problem hiding this comment.
I think those are just ideas. The api is not described from what I read.
5 participants
Proposed change
Plex does not support the standard protocols for discovery (SSDP, zeroconf) and the legacy
netdiscodiscovery didn't provide a unique ID. The underlying library now supports GDM discovery which can be triggered by a call to the integration.This PR doesn't add any code that's directly called yet, but sets up the ability to trigger discovery on demand during onboarding.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: