Skip to content

UniFi - Support SSID filter of SSIDs from access points with extra configuration#35295

Merged
balloob merged 1 commit into
home-assistant:devfrom
Kane610:unifi-support_ssid_override_from_access_points
May 6, 2020
Merged

UniFi - Support SSID filter of SSIDs from access points with extra configuration#35295
balloob merged 1 commit into
home-assistant:devfrom
Kane610:unifi-support_ssid_override_from_access_points

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented May 6, 2020 •
edited
Loading

Breaking change

Proposed change

Apparently there is a third way that UniFi stores SSIDs...
This will be reflected in library as well, but additional changes to library should be kept out from 0.109 release

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Kane610 Kane610 added this to the 0.109.5 milestone May 6, 2020
@Kane610 Kane610 self-assigned this May 6, 2020
balloob
balloob approved these changes May 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@balloob balloob merged commit 5218b23 into home-assistant:dev May 6, 2020
balloob pushed a commit that referenced this pull request May 7, 2020
@Kane610 @balloob
UniFi - Support SSID filter of SSIDs from access points with extra co…
6518249 
…nfiguration (#35295)
@balloob balloob mentioned this pull request May 7, 2020
Merged
@Kane610 Kane610 deleted the unifi-support_ssid_override_from_access_points branch May 7, 2020 06:55
Kane610 added a commit to Kane610/home-assistant that referenced this pull request May 7, 2020
@Kane610
Bump dependency to v21
62097f7 
Update fix from home-assistant#35295 to use library
Kane610 added a commit that referenced this pull request May 7, 2020
@Kane610
UniFi - Make devices proper push based (#35152)
53f64ba 
* Make devices proper push based

* Improve tests

* Bump dependency to v21
Update fix from #35295 to use library
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob approved these changes

Assignees

@Kane610 Kane610

Labels

bugfix cherry-picked cla-signed has-tests integration: unifi small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.109.5

Development

Successfully merging this pull request may close these issues.

Unifi Integration not working with separated 2-5GHz SSID networks

3 participants

@Kane610 @balloob @homeassistant