Skip to content

Upgrade zeroconf to 0.26.1 to resolve performance regression#35291

Merged
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:zeroconf_performance_regression_bump_dep
May 6, 2020
Merged

Upgrade zeroconf to 0.26.1 to resolve performance regression#35291
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:zeroconf_performance_regression_bump_dep

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 6, 2020

Proposed change

Home Assistant locked up on me last night and tracked it down to this.

Changelog: python-zeroconf/python-zeroconf@4c359e2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added core integration: zeroconf small-pr PRs with less than 30 lines. dependency-bump Pull requests that update a dependency file labels May 6, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco merged commit b353060 into home-assistant:dev May 6, 2020
@dshokouhi
Copy link
Copy Markdown
Member

Should this be tagged for a milestone release? Sounds like something we may want to push faster if systems are locking up.

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 6, 2020

Should this be tagged for a milestone release? Sounds like something we may want to push faster if systems are locking up.

The version with the performance regression was only in 0.110dev

@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core dependency-bump Pull requests that update a dependency file integration: zeroconf small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants