Skip to content

Add current step that is in progress#35272

Merged
balloob merged 2 commits intodevfrom
add-step-progress
May 6, 2020
Merged

Add current step that is in progress#35272
balloob merged 2 commits intodevfrom
add-step-progress

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 5, 2020

Breaking change

Proposed change

This adds the step that the flow in progress is currently on.

Needed to implement home-assistant/architecture#377

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (config) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit 1c5b4db into dev May 6, 2020
@balloob balloob deleted the add-step-progress branch May 6, 2020 04:34
@elupus
Copy link
Copy Markdown
Contributor

elupus commented May 6, 2020

Would be nice if the post command from frontend also included the step and was verified. I've had situation where frontend and backends state got out of sync, and post data was given to wrong step handler. Only happened during development mind you so might not be a big issue.

Also allowing GET request returning cached current step response would simplify frontend in some cases I think.

@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants