Skip to content

Broader Notion exception handling#35265

Merged
bachya merged 1 commit intohome-assistant:devfrom
bachya:fix-35253
May 5, 2020
Merged

Broader Notion exception handling#35265
bachya merged 1 commit intohome-assistant:devfrom
bachya:fix-35253

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented May 5, 2020

Proposed change

This integration broadens Notion's exception handling to cover unusual cases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bachya bachya self-assigned this May 5, 2020
@bachya bachya added this to the 0.109.5 milestone May 5, 2020
@bachya bachya merged commit 87d58a5 into home-assistant:dev May 5, 2020
@bachya bachya deleted the fix-35253 branch May 5, 2020 19:56
balloob pushed a commit that referenced this pull request May 7, 2020
@balloob balloob mentioned this pull request May 7, 2020
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled Notion exception

3 participants