Fix fan not checking supported_features#35248
Merged
MartinHjelmare merged 6 commits intohome-assistant:devfrom May 6, 2020
Merged
Fix fan not checking supported_features#35248MartinHjelmare merged 6 commits intohome-assistant:devfrom
MartinHjelmare merged 6 commits intohome-assistant:devfrom
Conversation
MartinHjelmare
requested changes
May 6, 2020
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Thanks! A small change needed below.
Also, have we checked that no other platforms need updating than the demo platform?
Please also update our developer docs and include oscillating, in the properties:
https://developers.home-assistant.io/docs/entity_fan#properties
Contributor
Author
|
@MartinHjelmare I don't have any other fan devices to check. But the tests all passed and I checked all integrations that supports fan. Only |
Member
|
Nice! Thanks for this @shenxn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix the problem that
FanEntity.capability_attributesandFanEntity.state_attributesdo not checksupported_features.Docs update:
home-assistant/developers.home-assistant#496
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: