Skip to content

Fix Islamic prayer sensor timestamp format#35243

Merged
MartinHjelmare merged 31 commits into
home-assistant:devfrom
engrbm87:islamic-prayer-config-flow
May 6, 2020
Merged

Fix Islamic prayer sensor timestamp format#35243
MartinHjelmare merged 31 commits into
home-assistant:devfrom
engrbm87:islamic-prayer-config-flow

Conversation

@engrbm87
Copy link
Copy Markdown
Contributor

@engrbm87 engrbm87 commented May 5, 2020

Proposed change

Add timezone info to sensor timestamp.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@engrbm87 engrbm87 changed the title Islamic prayer config flow Fix Islamic prayer sensor timestamp format May 5, 2020
Comment thread homeassistant/components/islamic_prayer_times/sensor.py Outdated
Comment thread homeassistant/components/islamic_prayer_times/translations/en.json Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 35d8890 into home-assistant:dev May 6, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

Should this go in a patch release?

@engrbm87
Copy link
Copy Markdown
Contributor Author

engrbm87 commented May 7, 2020

Currently only the ios mobile application is showing wrong time. Android app and the web browser are working fine.

@engrbm87 engrbm87 mentioned this pull request May 7, 2020
@balloob balloob added this to the 0.109.6 milestone May 7, 2020
@talondnb
Copy link
Copy Markdown

talondnb commented May 8, 2020

This seems to have broken the times for me.

Screen Shot 2020-05-08 at 22 19 28

I've tried removing integration and re-adding and also tried changing the calculation method, but still shows the wrong times.

edit: rolling back to 0.109.5 has fixed this for me.

Screen Shot 2020-05-08 at 22 40 30

@engrbm87
Copy link
Copy Markdown
Contributor Author

engrbm87 commented May 8, 2020

This seems to have broken the times for me.

Screen Shot 2020-05-08 at 22 19 28

I've tried removing integration and re-adding and also tried changing the calculation method, but still shows the wrong times.

edit: rolling back to 0.109.5 has fixed this for me.

Screen Shot 2020-05-08 at 22 40 30

Please submit an issue for tracking. And mention the sensor state value (timestamp)

@webhostsg
Copy link
Copy Markdown

This seems to have broken the times for me.

Screen Shot 2020-05-08 at 22 19 28

I've tried removing integration and re-adding and also tried changing the calculation method, but still shows the wrong times.

edit: rolling back to 0.109.5 has fixed this for me.

Screen Shot 2020-05-08 at 22 40 30

Same issue for me had to roll back to 0.109.5, sensor showing UTC time instead of the current local time..

@talondnb
Copy link
Copy Markdown

This seems to have broken the times for me.
Screen Shot 2020-05-08 at 22 19 28
I've tried removing integration and re-adding and also tried changing the calculation method, but still shows the wrong times.
edit: rolling back to 0.109.5 has fixed this for me.
Screen Shot 2020-05-08 at 22 40 30

Same issue for me had to roll back to 0.109.5, sensor showing UTC time instead of the current local time..

Please see home-assistant/home-assistant.io#13361

@home-assistant home-assistant locked as resolved and limited conversation to collaborators May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prayer times not showing up correctly on mobile but correctly on all other web/desktop platforms

6 participants