Fix pyload API statusServer doesn't take parameters#35242
Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom May 6, 2020
h4de5:pyload-sensor-api
Merged
Fix pyload API statusServer doesn't take parameters#35242MartinHjelmare merged 2 commits intohome-assistant:devfrom h4de5:pyload-sensor-api
MartinHjelmare merged 2 commits intohome-assistant:devfrom
h4de5:pyload-sensor-api
Conversation
Remove json payload from API call to statusServer for retrieving current download speed. See maintainers message in: pyload/pyload#3622 (comment) Skip duplicated call to update function.
remove empty line
MartinHjelmare
approved these changes
May 6, 2020
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Thanks! This is ok since it only removes code. We won't allow any additions to this integration though since the service specific interface code and data parsing should be moved to a standalone library published on pypi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Pyload's API method "statusServer" never accepted parameters. A recent update to payload's integrated webserver (which fixed the SSL connection handling) enforced this rule. Therefor the sensor no longer worked.
Remove json payload from API call to statusServer for retrieving current download speed.
Skip duplicated call to update function.
Type of change
Example entry for
configuration.yaml:no changes
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: