Skip to content

Fix pyload API statusServer doesn't take parameters#35242

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
h4de5:pyload-sensor-api
May 6, 2020
Merged

Fix pyload API statusServer doesn't take parameters#35242
MartinHjelmare merged 2 commits intohome-assistant:devfrom
h4de5:pyload-sensor-api

Conversation

@h4de5
Copy link
Copy Markdown
Contributor

@h4de5 h4de5 commented May 5, 2020

Proposed change

Pyload's API method "statusServer" never accepted parameters. A recent update to payload's integrated webserver (which fixed the SSL connection handling) enforced this rule. Therefor the sensor no longer worked.

Remove json payload from API call to statusServer for retrieving current download speed.
Skip duplicated call to update function.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

no changes

sensor:
  - platform: pyload
    host: yourhost.com
    port: 8001
    name: pyLoad
    username: pyload
    password: !secret pyload_login
    ssl: true

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Remove json payload from API call to statusServer for retrieving current download speed. 
See maintainers message in: pyload/pyload#3622 (comment)

Skip duplicated call to update function.
remove empty line
@MartinHjelmare MartinHjelmare changed the title pyload API statusServer doesn't take parameters Fix pyload API statusServer doesn't take parameters May 6, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is ok since it only removes code. We won't allow any additions to this integration though since the service specific interface code and data parsing should be moved to a standalone library published on pypi.

@MartinHjelmare MartinHjelmare merged commit 14190bd into home-assistant:dev May 6, 2020
@h4de5 h4de5 deleted the pyload-sensor-api branch May 6, 2020 19:40
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants