Skip to content

Fix Synology DSM sensor to be False or 0#35208

Merged
Quentame merged 1 commit intohome-assistant:devfrom
Quentame:synology_dsm/fix-sensor
May 4, 2020
Merged

Fix Synology DSM sensor to be False or 0#35208
Quentame merged 1 commit intohome-assistant:devfrom
Quentame:synology_dsm/fix-sensor

Conversation

@Quentame
Copy link
Copy Markdown
Member

@Quentame Quentame commented May 4, 2020

Proposed change

Fixes #35181, whoops, introduced in 0.109.3 😬

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Quentame Quentame added this to the 0.109.4 milestone May 4, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration (synology_dsm) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Quentame
Copy link
Copy Markdown
Member Author

Quentame commented May 4, 2020

Working
image

@Quentame
Copy link
Copy Markdown
Member Author

Quentame commented May 4, 2020

Merging since no test about it and manually tested

@Quentame Quentame merged commit 94b6130 into home-assistant:dev May 4, 2020
@Quentame Quentame deleted the synology_dsm/fix-sensor branch May 4, 2020 21:19
@balloob balloob mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Synology sensors have gone in 0.109.3

3 participants