Skip to content

Make sure MQTT light brightness is not rounded to 0#35207

Merged
balloob merged 1 commit intohome-assistant:devfrom
emontnemery:mqtt_light_min_brightness
May 4, 2020
Merged

Make sure MQTT light brightness is not rounded to 0#35207
balloob merged 1 commit intohome-assistant:devfrom
emontnemery:mqtt_light_min_brightness

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Proposed change

Make sure MQTT light brightness is not rounded to 0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit f9b420a into home-assistant:dev May 4, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
@emontnemery emontnemery deleted the mqtt_light_min_brightness branch June 10, 2020 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dimmer slider turning off light for MQTT but not other dimmers

3 participants