Skip to content

Move life360 I/O out of event loop in config flow#35193

Merged
pnbruckner merged 1 commit intodevfrom
life360-config_flow
May 4, 2020
Merged

Move life360 I/O out of event loop in config flow#35193
pnbruckner merged 1 commit intodevfrom
life360-config_flow

Conversation

@pnbruckner
Copy link
Copy Markdown
Contributor

Proposed change

Life360 config flow performed I/O in the event loop. This change fixes that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnbruckner pnbruckner merged commit d8ebdda into dev May 4, 2020
@pnbruckner pnbruckner deleted the life360-config_flow branch May 4, 2020 19:58
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

life360 Detection of blocking I/O in the event loop

3 participants