Skip to content

Fix Canary KeyError: 'ffmpeg_arguments'#35158

Merged
frenck merged 2 commits into
devfrom
frenck-2020-0465
May 4, 2020
Merged

Fix Canary KeyError: 'ffmpeg_arguments'#35158
frenck merged 2 commits into
devfrom
frenck-2020-0465

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented May 3, 2020

Proposed change

Fixes Canary KeyError during setup.

        Traceback (most recent call last):
          File "/home/lee/homeassistant/lib/python3.7/site-packages/homeassistant/helpers/entity_platform.py", line 178, in _async_setup_platform
            await asyncio.wait_for(asyncio.shield(task), SLOW_SETUP_MAX_WAIT)
          File "/usr/lib/python3.7/asyncio/tasks.py", line 442, in wait_for
            return fut.result()
          File "/usr/lib/python3.7/concurrent/futures/thread.py", line 57, in run
            result = self.fn(*self.args, **self.kwargs)
          File "/home/lee/homeassistant/lib/python3.7/site-packages/homeassistant/components/canary/camera.py", line 45, in setup_platform
            config[CONF_FFMPEG_ARGUMENTS],
        KeyError: 'ffmpeg_arguments'

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added integration: canary small-pr PRs with less than 30 lines. labels May 3, 2020
@frenck frenck added this to the 0.109.4 milestone May 3, 2020
Comment thread homeassistant/components/canary/alarm_control_panel.py Outdated
@frenck frenck force-pushed the frenck-2020-0465 branch from 84ab027 to df0c950 Compare May 3, 2020 23:25
@frenck frenck merged commit 96a998a into dev May 4, 2020
@frenck frenck deleted the frenck-2020-0465 branch May 4, 2020 08:35
@balloob balloob mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while setting up canary platform for camera

4 participants