Reset imap email content state if no email#35123
Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom May 6, 2020
Merged
Reset imap email content state if no email#35123MartinHjelmare merged 3 commits intohome-assistant:devfrom
MartinHjelmare merged 3 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
breaking-change
integration: imap_email_content
new-feature
small-pr
MartinHjelmare
requested changes
May 3, 2020
| if email_message is None: | ||
| self._message = "unknown" | ||
| self._state_attributes = { | ||
| ATTR_FROM: "unknown", |
Member
There was a problem hiding this comment.
Our standard is to not add the item at all to state attributes if the value is unknown.
| email_message = self._email_reader.read_next() | ||
|
|
||
| if email_message is None: | ||
| self._message = "unknown" |
Member
There was a problem hiding this comment.
Use None to represent unknown state.
MartinHjelmare
changed the title
Contributor
Author
|
Ok, I will work on this. It will require time, because I have to test if all also works with None. :-D |
Contributor
I think this sensor is inherently hard to use. How about firing new emails as events? |
Contributor
Author
|
I am not deep inside this application. I can do the event thing at a later stage... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
There is a breaking change: The state of the imap_email_content is replaced when there is no email found. The current implementation does not change state if there is no matching email; meaning even if one deletes the matching email, the state still shows that email. This is IMHO wrong and annoying and makes it very complicated to use this sensor. With this change any other thing like an automation can react onto the arrival of an email
Proposed change
Replace the state of the sensor with unknown if there is no matching email at all.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: