Skip to content

Use asynctest-mock in most places#35109

Merged
balloob merged 2 commits intodevfrom
use-asynctest-mock
May 3, 2020
Merged

Use asynctest-mock in most places#35109
balloob merged 2 commits intodevfrom
use-asynctest-mock

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 3, 2020

Breaking change

Proposed change

Migrate to always using the same patch function from tests.asynctest_mock. That way we will also teach new people writing tests to do it the right way.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob
Copy link
Copy Markdown
Member Author

balloob commented May 3, 2020

This was done in a big swoop by updating all test files that did not use mock_coro. I ran tests locally and seems fine, if not too many tests fail I'll fix it up and we can merge it. If too many tests fail I'll bail 😅

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering your comment... I would say this was a smooth sail ⛵️

👍

@balloob balloob merged commit 2af9849 into dev May 3, 2020
@delete-merged-branch delete-merged-branch Bot deleted the use-asynctest-mock branch May 3, 2020 18:27
@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants