Skip to content

Use suggestd_value instead of default in Monoprice options flow #35107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 1 commit into from
May 3, 2020
Merged

Use suggestd_value instead of default in Monoprice options flow #35107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion homeassistant/components/monoprice/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ def async_get_options_flow(config_entry):
@core.callback
def _key_for_source(index, source, previous_sources):
if str(index) in previous_sources:
key = vol.Optional(source, default=previous_sources[str(index)])
key = vol.Optional(
source, description={"suggested_value": previous_sources[str(index)]}
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has suggested_value been documented in our developer docs?

Copy link
Copy Markdown
Contributor Author

@OnFreund OnFreund May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't. I couldn't find any place where the use of schema for config flows was documented at all, so didn't really know where to put this.
More than happy to update the docs to reflect this if there's a relevant place.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document it here:
https://developers.home-assistant.io/docs/data_entry_flow_index#show-form

Copy link
Copy Markdown
Contributor Author

@OnFreund OnFreund May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

home-assistant/developers.home-assistant#492

)
else:
key = vol.Optional(source)

Expand Down