Skip to content

Show device details in homekit accessory service info#35100

Merged
bdraco merged 2 commits intohome-assistant:devfrom
bdraco:homekit_show_platform
May 11, 2020
Merged

Show device details in homekit accessory service info#35100
bdraco merged 2 commits intohome-assistant:devfrom
bdraco:homekit_show_platform

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 3, 2020

Proposed change

  • We now know which integration provides the
    accessory most of the time so we can show it
    instead of the generic placeholder.

Screen Shot 2020-05-02 at 8 05 03 PM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 3, 2020

I'm going to do a bit more cleanup

@bdraco bdraco force-pushed the homekit_show_platform branch from bd4ec2c to 38089b1 Compare May 3, 2020 16:22
@bdraco bdraco marked this pull request as ready for review May 3, 2020 16:26
@Jc2k
Copy link
Copy Markdown
Member

Jc2k commented May 4, 2020

Nice. Can we do this via the device registry and pull the manufacturer/model as it is stored rather than trying to reconsitute it with .title()? Would be able to get the firmware version that way as well?

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 4, 2020

Nice. Can we do this via the device registry and pull the manufacturer/model as it is stored rather than trying to reconsitute it with .title()? Would be able to get the firmware version that way as well?

I was thinking about doing that in a followup when I find the need to use the device registry for something else. This one was easy since we already get the entity registry. I did a bit of testing with the firmware and HomeKit has strong requirements on the formatting of the versioning so I don't think it is possible.

@bdraco bdraco force-pushed the homekit_show_platform branch 2 times, most recently from 12f3836 to 449c878 Compare May 5, 2020 00:24
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 5, 2020

Converting to draft since this is going to cause a conflict with #35238 and I don't want to discourage contributions because of conflicts.

@bdraco bdraco marked this pull request as draft May 5, 2020 18:53
@bdraco bdraco force-pushed the homekit_show_platform branch 2 times, most recently from 272afef to 517fb19 Compare May 6, 2020 21:34
@bdraco bdraco marked this pull request as ready for review May 6, 2020 21:34
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 6, 2020

@Jc2k I did some more testing with this and was able to get your device registry suggestion implemented.

@bdraco bdraco changed the title Show platform in homekit accessory service info Show device details in homekit accessory service info May 6, 2020
@Jc2k
Copy link
Copy Markdown
Member

Jc2k commented May 6, 2020

Nice one!

Comment thread homeassistant/components/homekit/accessories.py Outdated
@bdraco bdraco force-pushed the homekit_show_platform branch from 788a77e to c890e89 Compare May 7, 2020 16:02
@bdraco bdraco mentioned this pull request May 9, 2020
20 tasks
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 10, 2020

Going to have to resquash to cleanup the conflict mess

@bdraco bdraco force-pushed the homekit_show_platform branch from 9e9b0c9 to c0f5a1e Compare May 10, 2020 22:54
@bdraco bdraco force-pushed the homekit_show_platform branch from c0f5a1e to 264c30e Compare May 11, 2020 13:22
@bdraco bdraco merged commit 0a9b373 into home-assistant:dev May 11, 2020
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants