Show device details in homekit accessory service info#35100
Show device details in homekit accessory service info#35100bdraco merged 2 commits intohome-assistant:devfrom
Conversation
|
I'm going to do a bit more cleanup |
bd4ec2c to
38089b1
Compare
|
Nice. Can we do this via the device registry and pull the manufacturer/model as it is stored rather than trying to reconsitute it with |
I was thinking about doing that in a followup when I find the need to use the device registry for something else. This one was easy since we already get the entity registry. I did a bit of testing with the firmware and |
12f3836 to
449c878
Compare
|
Converting to draft since this is going to cause a conflict with #35238 and I don't want to discourage contributions because of conflicts. |
272afef to
517fb19
Compare
|
@Jc2k I did some more testing with this and was able to get your device registry suggestion implemented. |
|
Nice one! |
788a77e to
c890e89
Compare
|
Going to have to resquash to cleanup the conflict mess |
9e9b0c9 to
c0f5a1e
Compare
c0f5a1e to
264c30e
Compare
Proposed change
accessory most of the time so we can show it
instead of the generic placeholder.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: