Skip to content

Simplify MQTT light brightness logic#35097

Merged
frenck merged 2 commits intohome-assistant:devfrom
LordMike:patch-1
May 3, 2020
Merged

Simplify MQTT light brightness logic#35097
frenck merged 2 commits intohome-assistant:devfrom
LordMike:patch-1

Conversation

@LordMike
Copy link
Copy Markdown
Contributor

@LordMike LordMike commented May 2, 2020

Proposed change

Simplify the code in a branch where the value checked will always be None. In this branch, self._brightness is always None, hence the removed code is unnecessary.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

In this if branch, `self._brightness` is always None, hence the if is unnecessary.
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @LordMike,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@LordMike LordMike changed the title Logic simplication Logic simplification May 2, 2020
@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, @emontnemery, mind taking a look at this pull request as its been labeled with a integration (mqtt) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@LordMike
Copy link
Copy Markdown
Contributor Author

LordMike commented May 3, 2020

Note: Python is not my first language. I was merely reading the code to understand more of why the mqtt integration "misbehaved".. (it didn't).

@MartinHjelmare MartinHjelmare changed the title Logic simplification Simplify mqtt light brightness logic May 3, 2020
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Please run black code formatter from the project root and commit the changes.

black --fast homeassistant

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LordMike 👍

@frenck frenck changed the title Simplify mqtt light brightness logic Simplify MQTT light brightness logic May 3, 2020
@frenck frenck merged commit e7fc886 into home-assistant:dev May 3, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants