Skip to content

Add type to device registry#35095

Merged
balloob merged 2 commits intodevfrom
add-device-registry-type
May 3, 2020
Merged

Add type to device registry#35095
balloob merged 2 commits intodevfrom
add-device-registry-type

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 2, 2020

Breaking change

Proposed change

Add a new entry_type to device registry to indicate if it is a device or a service. If None (default) it's a device, if it's service, it's a service.

Added it to AdGuard so we can test it in the frontend :)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare
Copy link
Copy Markdown
Member

Do we need to update the entity platform helper?

"connections",
"identifiers",
"manufacturer",
"model",
"name",
"sw_version",
"via_device",

@balloob
Copy link
Copy Markdown
Member Author

balloob commented May 3, 2020

doh yes. And I should add a test for that 😅

@balloob balloob force-pushed the add-device-registry-type branch from 10b4f11 to b4cf1a6 Compare May 3, 2020 20:12
@balloob balloob merged commit b90cb09 into dev May 3, 2020
@balloob balloob deleted the add-device-registry-type branch May 3, 2020 20:57
@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type attribute to devices

4 participants