Skip to content

Check isinstance on collections.abc, not typing classes#35087

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
scop:abc-instanceof
May 2, 2020
Merged

Check isinstance on collections.abc, not typing classes#35087
MartinHjelmare merged 1 commit intohome-assistant:devfrom
scop:abc-instanceof

Conversation

@scop
Copy link
Copy Markdown
Member

@scop scop commented May 2, 2020

Proposed change

collections.abc types are the proper ones to do instanceof checks with. Upcoming pylint 2.5.0 will flag these.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @andrewsayre, mind taking a look at this pull request as its been labeled with a integration (smartthings) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare merged commit 752679c into home-assistant:dev May 2, 2020
@scop scop deleted the abc-instanceof branch May 2, 2020 22:07
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants