Skip to content

Add required features to cover service registration#35073

Merged
MartinHjelmare merged 4 commits intodevfrom
add-cover-service-features
May 3, 2020
Merged

Add required features to cover service registration#35073
MartinHjelmare merged 4 commits intodevfrom
add-cover-service-features

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented May 2, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Made me realize we have a SERVICE_STOP_COVER but not STATE_STOPPED

@MartinHjelmare
Copy link
Copy Markdown
Member Author

The state is most likely open if the cover was stopped.

@MartinHjelmare MartinHjelmare merged commit 39431c0 into dev May 3, 2020
@delete-merged-branch delete-merged-branch Bot deleted the add-cover-service-features branch May 3, 2020 21:21
@bdraco
Copy link
Copy Markdown
Member

bdraco commented May 3, 2020

The state is most likely open if the cover was stopped.

For sure, I'm mapping it that way for homekit. There is a Going to the minimum value (closing), Going to the maximum value (opening), and Stopped (no representation currently). Anyways, not really related to this PR.

@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants