Skip to content

Fix vera config ids not being converted to integers#35070

Merged
balloob merged 2 commits intohome-assistant:devfrom
vangorra:rvangork_vera_fixes
May 2, 2020
Merged

Fix vera config ids not being converted to integers#35070
balloob merged 2 commits intohome-assistant:devfrom
vangorra:rvangork_vera_fixes

Conversation

@vangorra
Copy link
Copy Markdown
Contributor

@vangorra vangorra commented May 2, 2020

Adding tests to confirm these config ids work properly.

Proposed change

Fixing bug that ignored the light ids and exclude ids options.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Adding tests to confirm these config ids work properly.
@vangorra vangorra changed the title Fixing config ids not being converted to ints. Fix config ids not being converted to ints. May 2, 2020
@MartinHjelmare MartinHjelmare changed the title Fix config ids not being converted to ints. Fix vera config ids not being converted to integers May 2, 2020
@balloob balloob merged commit ab08c1b into home-assistant:dev May 2, 2020
@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants