Skip to content

Remove some passings of loop #34995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
May 1, 2020
Merged

Remove some passings of loop #34995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/rflink/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ async def connect():
)

try:
with async_timeout.timeout(CONNECTION_TIMEOUT, loop=hass.loop):
with async_timeout.timeout(CONNECTION_TIMEOUT):
transport, protocol = await connection

except (
Expand Down
2 changes: 0 additions & 2 deletions homeassistant/components/shell_command/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ async def async_service_handler(service: ServiceCall) -> None:
# pylint: disable=no-member
create_process = asyncio.subprocess.create_subprocess_shell(
cmd,
loop=hass.loop,
stdin=None,
stdout=asyncio.subprocess.PIPE,
stderr=asyncio.subprocess.PIPE,
Expand All @@ -69,7 +68,6 @@ async def async_service_handler(service: ServiceCall) -> None:
# pylint: disable=no-member
create_process = asyncio.subprocess.create_subprocess_exec(
*shlexed_cmd,
loop=hass.loop,
stdin=None,
stdout=asyncio.subprocess.PIPE,
stderr=asyncio.subprocess.PIPE,
Expand Down
1 change: 0 additions & 1 deletion homeassistant/components/tradfri/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ async def async_setup_entry(hass, entry):
entry.data[CONF_HOST],
psk_id=entry.data[CONF_IDENTITY],
psk=entry.data[CONF_KEY],
loop=hass.loop,
)

async def on_hass_stop(event):
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/tradfri/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ async def get_gateway_info(hass, host, identity, key):
"""Return info for the gateway."""

try:
factory = APIFactory(host, psk_id=identity, psk=key, loop=hass.loop)
factory = APIFactory(host, psk_id=identity, psk=key)

api = factory.request
gateway = Gateway()
Expand Down
9 changes: 2 additions & 7 deletions homeassistant/helpers/aiohttp_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,7 @@ def async_create_clientsession(
connector = _async_get_connector(hass, verify_ssl)

clientsession = aiohttp.ClientSession(
loop=hass.loop,
connector=connector,
headers={USER_AGENT: SERVER_SOFTWARE},
**kwargs,
connector=connector, headers={USER_AGENT: SERVER_SOFTWARE}, **kwargs,
)

if auto_cleanup:
Expand Down Expand Up @@ -174,9 +171,7 @@ def _async_get_connector(
else:
ssl_context = False

connector = aiohttp.TCPConnector(
loop=hass.loop, enable_cleanup_closed=True, ssl=ssl_context
)
connector = aiohttp.TCPConnector(enable_cleanup_closed=True, ssl=ssl_context)
hass.data[key] = connector

async def _async_close_connector(event: Event) -> None:
Expand Down