Skip to content

Add zwave mqtt#34987

Merged
MartinHjelmare merged 52 commits intodevfrom
add-zwave_mqtt
May 3, 2020
Merged

Add zwave mqtt#34987
MartinHjelmare merged 52 commits intodevfrom
add-zwave_mqtt

Conversation

@MartinHjelmare
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare commented Apr 30, 2020

Breaking change

Proposed change

  • Add a base for the new zwave_mqtt integration. This integration has been in testing as a custom component for some time:
    https://github.com/cgarwood/homeassistant-zwave_mqtt
  • Tests are not added for all modules yet. I plan to iterate on that in future PRs.
  • We only add the switch platform in this first PR to keep the scope smaller. It's still a big PR. Further platforms will be added one by one.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Comment thread .pre-commit-config.yaml Outdated
Comment thread homeassistant/components/zwave_mqtt/__init__.py Outdated
MartinHjelmare and others added 2 commits May 1, 2020 02:04
Comment thread tests/components/zwave_mqtt/conftest.py Outdated
@MartinHjelmare MartinHjelmare merged commit aeb8916 into dev May 3, 2020
@MartinHjelmare MartinHjelmare deleted the add-zwave_mqtt branch May 3, 2020 00:54
@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants