Skip to content

Fix Toon doing I/O in event loop #34896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bachya merged 1 commit into from
Apr 29, 2020
Merged

Fix Toon doing I/O in event loop #34896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/toon/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ async def async_setup_entry(hass: HomeAssistantType, entry: ConfigType) -> bool:
)
hass.data.setdefault(DATA_TOON_CLIENT, {})[entry.entry_id] = toon

toon_data = ToonData(hass, entry, toon)
toon_data = await hass.async_add_executor_job(ToonData, hass, entry, toon)
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side effects in init method. 🙈

Copy link
Copy Markdown
Member

@frenck frenck Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thing is going to be replaced in total for 0.110 or 0.111...

hass.data.setdefault(DATA_TOON, {})[entry.entry_id] = toon_data
async_track_time_interval(hass, toon_data.update, conf[CONF_SCAN_INTERVAL])

Expand Down