Skip to content

Update pydaikin to 2.0.0#34807

Merged
MartinHjelmare merged 6 commits intohome-assistant:devfrom
fredrike:daikin-2.0
May 6, 2020
Merged

Update pydaikin to 2.0.0#34807
MartinHjelmare merged 6 commits intohome-assistant:devfrom
fredrike:daikin-2.0

Conversation

@fredrike
Copy link
Copy Markdown
Contributor

@fredrike fredrike commented Apr 28, 2020

Proposed change

Update pydaikin to version 2.0.0.

pydaikin v2.0.0 adds support for:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

I'm planning to decommissionconfiguration.yaml as not all settings is available trough that atm and bc: https://www.home-assistant.io/blog/2020/04/14/the-future-of-yaml/. But as that will be a breaking change it will be a separate PR.

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@fredrike fredrike changed the title WIP: Update pydaikin to 2.0.0 Update pydaikin to 2.0.0 May 4, 2020
Comment thread tests/components/daikin/test_config_flow.py
Comment thread homeassistant/components/daikin/config_flow.py Outdated
Comment thread homeassistant/components/daikin/config_flow.py Outdated
@fredrike
Copy link
Copy Markdown
Contributor Author

fredrike commented May 5, 2020

What does new-feature imply? That it won't be merged to master until 0.111?

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented May 5, 2020

The window for 0.110.0 is still open. The beta cut for that is next week on Wednesday.

Comment thread tests/components/daikin/test_config_flow.py
Comment thread tests/components/daikin/test_config_flow.py Outdated
@fredrike
Copy link
Copy Markdown
Contributor Author

fredrike commented May 5, 2020

The window for 0.110.0 is still open. The beta cut for that is next week on Wednesday.

I've tried to keep this change as small as possible but it is indeed a big change with support for new units.

I'm planning of removing yaml support in a new pr.

@fredrike fredrike requested a review from MartinHjelmare May 5, 2020 17:04
Comment thread homeassistant/components/daikin/config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@MartinHjelmare MartinHjelmare merged commit d8222a8 into home-assistant:dev May 6, 2020
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants