Fix Dockerfile.dev#34747
Closed
jbergler wants to merge 1 commit intohome-assistant:devfrom
Closed
Conversation
Contributor
home-assistant#34654 broke the dev dockerfile, so I'm trying to fix it. - fix the leading && by putting a valid no-op command before it to maintain formatting - remove the apt-add-repository, it's unclear why it was added and it's broken. - also add a CI step that tries to build the dockerfile to validate it.
Member
Member
|
For dockerfile, hadolint is the feature: #34758 Yeah, the ffmpeg part was a copy past issue from our azure ci dockerfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#34654 broke the dev dockerfile, so I'm trying to fix it.
Proposed change
Type of change
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: