Skip to content

Fix Dockerfile.dev#34747

Closed
jbergler wants to merge 1 commit intohome-assistant:devfrom
jbergler:dev
Closed

Fix Dockerfile.dev#34747
jbergler wants to merge 1 commit intohome-assistant:devfrom
jbergler:dev

Conversation

@jbergler
Copy link
Copy Markdown
Contributor

@jbergler jbergler commented Apr 27, 2020

#34654 broke the dev dockerfile, so I'm trying to fix it.

Proposed change

  • fix the leading && by putting a valid no-op command before it to maintain formatting
  • remove the apt-add-repository, it's unclear why it was added and it's broken.
  • also add a CI step that tries to build the dockerfile to validate it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @jbergler,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant#34654 broke the dev dockerfile, so I'm trying to fix it.

- fix the leading && by putting a valid no-op command before it to maintain formatting
- remove the apt-add-repository, it's unclear why it was added and it's broken.
- also add a CI step that tries to build the dockerfile to validate it.
@jbergler jbergler mentioned this pull request Apr 27, 2020
20 tasks
@balloob balloob requested a review from pvizeli April 27, 2020 05:57
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Apr 27, 2020

2cae17d

@pvizeli pvizeli closed this Apr 27, 2020
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Apr 27, 2020

For dockerfile, hadolint is the feature: #34758

Yeah, the ffmpeg part was a copy past issue from our azure ci dockerfile

@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants