Change Modbus switch to use verify_register when defined#34679
Change Modbus switch to use verify_register when defined#34679MartinHjelmare merged 1 commit intohome-assistant:devfrom janiversen:modbuspatch2
Conversation
Writing to holding register "register" and reading from "verify_register" if defined else "register". Verify_state is not used.
|
Hey there @adamchengtkc, mind taking a look at this pull request as its been labeled with a integration ( |
|
Should this go out in a patch release? |
|
yes please, but just when there are other reasons to make a patch release. thanks for merging, I understand the problem with not having time....the project could with a couple “well trained” senior voluntary programmers. If it is considered then I am happy to help (I am a pensionist with time at hand and a lifetime of experience, since 1975. |
|
Review help is very appreciated! Just go for it. You're welcome to ask for a second opinion when needed. I review all merged PRs briefly and will give feedback at that point when needed. I recommend checking our developer docs for architecture design guidelines. |
Breaking change
Proposed change
Writing to holding register "register" and reading from "verify_register"
if defined else "register".
Verify_state is not used.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
This PR fixes or closes issue: fixes #
fixes modbus switch - verify_register ignored #33163
This PR is related to issue:
Link to documentation pull request:
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: