Skip to content

Change Modbus switch to use verify_register when defined#34679

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
janiversen:modbuspatch2
May 6, 2020
Merged

Change Modbus switch to use verify_register when defined#34679
MartinHjelmare merged 1 commit intohome-assistant:devfrom
janiversen:modbuspatch2

Conversation

@janiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Writing to holding register "register" and reading from "verify_register"
if defined else "register".

Verify_state is not used.

Type of change

  • Dependency upgrade
  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • [x ] The code change is tested and works locally.
  • [ x] Local tests pass. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the development checklist
  • [x ] The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Writing to holding register "register" and reading from "verify_register"
if defined else "register".

Verify_state is not used.
@probot-home-assistant
Copy link
Copy Markdown

Hey there @adamchengtkc, mind taking a look at this pull request as its been labeled with a integration (modbus) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Modbus: Changed switch to use verify_register when defined Change Modbus switch to use verify_register when defined Apr 25, 2020
@janiversen janiversen mentioned this pull request May 6, 2020
20 tasks
@MartinHjelmare MartinHjelmare merged commit 1b02410 into home-assistant:dev May 6, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

Should this go out in a patch release?

@janiversen
Copy link
Copy Markdown
Member Author

yes please, but just when there are other reasons to make a patch release.

thanks for merging, I understand the problem with not having time....the project could with a couple “well trained” senior voluntary programmers. If it is considered then I am happy to help (I am a pensionist with time at hand and a lifetime of experience, since 1975.

@janiversen janiversen deleted the modbuspatch2 branch May 6, 2020 12:21
@MartinHjelmare MartinHjelmare added this to the 0.109.5 milestone May 6, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

Review help is very appreciated! Just go for it. You're welcome to ask for a second opinion when needed. I review all merged PRs briefly and will give feedback at that point when needed.

I recommend checking our developer docs for architecture design guidelines.
https://developers.home-assistant.io/docs/architecture_index

@balloob balloob mentioned this pull request May 7, 2020
@lock lock Bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modbus switch - verify_register ignored

4 participants