Add retry on empty modbus messages for serial protocol#34678
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom May 6, 2020
janiversen:modbuspatch1
Merged
Add retry on empty modbus messages for serial protocol#34678MartinHjelmare merged 1 commit intohome-assistant:devfrom janiversen:modbuspatch1
MartinHjelmare merged 1 commit intohome-assistant:devfrom
janiversen:modbuspatch1
Conversation
Some devices send a 0 byte message for no obvious reason, this causes a failed transaction. Instead do a retry and see if the device do respond at all.
|
Hey there @adamchengtkc, mind taking a look at this pull request as its been labeled with a integration ( |
20 tasks
MartinHjelmare
approved these changes
May 6, 2020
Member
|
Patch release? |
Member
Author
|
yes please, but just when there are other reasons to make a patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Some devices send a 0 byte message for no obvious reason, this causes
a failed transaction. Instead do a retry and see if the device do respond
at all.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
It might not solve #34541, but at least partial, as well as a number of similar cases.
#14902 and #18128 should be solved with 0.108.8, but this PR makes it more robust.
fixes modbus: one of the registers shows unavailable after an upgrade from 0.107.7 #34541
fixes No response from RS485 Modbus RTU device - updating took longer than the scheduled #28577
fixes Modbus: RTU frames sending to bus without delay #19402
fixes Modbus RS485 unreliable communication #18128
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: