Conversation
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
pvizeli
reviewed
Apr 24, 2020
| @@ -184,6 +184,7 @@ | |||
| EVENT_CORE_CONFIG_UPDATE = "core_config_updated" | |||
| EVENT_HOMEASSISTANT_CLOSE = "homeassistant_close" | |||
Member
There was a problem hiding this comment.
Maybe we should rename this event in that case to EVENT_HOMEASSISTANT_STOPPED
Member
Author
There was a problem hiding this comment.
Too late :) I think close is fine.
pvizeli
approved these changes
Apr 24, 2020
bdraco
approved these changes
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Introduce a new event that is fired when Home Assistant has finished the startup. This includes finishing the setup and the starting phase. This allows scheduling work that really needs all startup work to be done, including writing unavailable states for entities that are no longer added.
Updated automatic Google Sync for cloud and automation to use the new event.
Fixes some edge cases where automations/Google Sync could get triggered during startup if certain tasks took a long time.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: