Skip to content

Add ability to ignore tado discovery #34650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 4 commits into from
Apr 25, 2020
Merged

Add ability to ignore tado discovery #34650

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e9061e
Add ability to ignore tado discovery
bdraco Apr 24, 2020
b83f3fc
update test
bdraco Apr 25, 2020
f9f1736
Update tests/components/tado/test_config_flow.py
bdraco Apr 25, 2020
ffc2047
Update tests/components/tado/test_config_flow.py
bdraco Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions homeassistant/components/tado/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ async def async_step_homekit(self, homekit_info):
# they already have one configured as they can always
# add a new one via "+"
return self.async_abort(reason="already_configured")
properties = {
key.lower(): value for (key, value) in homekit_info["properties"].items()
}
await self.async_set_unique_id(properties["id"])
return await self.async_step_user()

async def async_step_import(self, user_input):
Expand Down
10 changes: 8 additions & 2 deletions tests/components/tado/test_config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,23 @@ async def test_form_homekit(hass):
await setup.async_setup_component(hass, "persistent_notification", {})

result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": "homekit"}
DOMAIN,
context={"source": "homekit"},
data={"properties": {"id": "AA:BB:CC:DD:EE:FF"}},
)
assert result["type"] == "form"
assert result["errors"] == {}
flows_in_progress = hass.config_entries.flow.async_progress()
Comment thread
bdraco marked this conversation as resolved.
Outdated
assert flows_in_progress[0]["context"]["unique_id"] == "AA:BB:CC:DD:EE:FF"
Comment thread
bdraco marked this conversation as resolved.
Outdated

entry = MockConfigEntry(
domain=DOMAIN, data={CONF_USERNAME: "mock", CONF_PASSWORD: "mock"}
)
entry.add_to_hass(hass)

result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": "homekit"}
DOMAIN,
context={"source": "homekit"},
data={"properties": {"id": "AA:BB:CC:DD:EE:FF"}},
)
assert result["type"] == "abort"