Skip to content

Add trend measurement config option for AirVisual#34626

Closed
bachya wants to merge 2 commits intohome-assistant:devfrom
bachya:airvisual-trends
Closed

Add trend measurement config option for AirVisual#34626
bachya wants to merge 2 commits intohome-assistant:devfrom
bachya:airvisual-trends

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Apr 24, 2020

Proposed change

This PR adds a config options flow for AirVisual Node/Pro units and adds one option: the number of measurements to use when calculating pollutant trends (with -1 equaling use all measurements).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bachya bachya self-assigned this Apr 24, 2020
@bachya bachya force-pushed the airvisual-trends branch from c6aa632 to e808298 Compare April 24, 2020 02:26
@bachya bachya changed the title Airvisual trends Add trend measurement config option for AirVisual Apr 24, 2020
@bachya bachya force-pushed the airvisual-trends branch from e808298 to 236c089 Compare April 24, 2020 16:01
@bachya bachya force-pushed the airvisual-trends branch from 236c089 to 85e72c2 Compare April 24, 2020 18:07
@bachya bachya marked this pull request as ready for review April 24, 2020 18:08
@bachya
Copy link
Copy Markdown
Contributor Author

bachya commented Apr 26, 2020

Thinking further: people should use the trend integration if they want to trend data from a Node/Pro; I don’t want to maintain functionality that can be replicated today.

@bachya bachya closed this Apr 26, 2020
@bachya bachya reopened this Apr 26, 2020
@bachya bachya closed this Apr 26, 2020
@bachya bachya deleted the airvisual-trends branch April 26, 2020 02:21
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants