Delay sync for Google and limit updates to relevant info#34622
Merged
Conversation
|
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
pvizeli
approved these changes
Apr 24, 2020
balloob
added a commit
that referenced
this pull request
Apr 24, 2020
Merged
balloob
added a commit
that referenced
this pull request
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Now that the cloud starts up faster, it was capturing entity registry changes it previously was not. Since Google does not allow partial sync like Alexa, it would update all entities, however, since this happened before Home Assistant was fully started, not all entities were loaded yet. Fixed this by using the delayed sync helper, which waits 15 seconds and is also used for preference updates.
Also updated both Alexa/Google entity registry listeners to only treat an entity registry update relevant if important attributes have changed.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: