Skip to content

Fix UVC doing I/O in event loop#34610

Merged
balloob merged 2 commits intodevfrom
fix-uvc-io
Apr 23, 2020
Merged

Fix UVC doing I/O in event loop#34610
balloob merged 2 commits intodevfrom
fix-uvc-io

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 23, 2020

Breaking change

Proposed change

Fix UVC integration doing I/O in the event loop

I did not test this change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob added this to the 0.109.0 milestone Apr 23, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saves a few calls as well 😄

@balloob balloob merged commit afe15a2 into dev Apr 23, 2020
@balloob balloob deleted the fix-uvc-io branch April 23, 2020 22:52
balloob added a commit that referenced this pull request Apr 24, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 25, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ubiquiti Unifi Video - Detected I/O inside the event loop

3 participants