Skip to content

Remember homekit aids for entities without a unique id#34587

Merged
bdraco merged 3 commits intohome-assistant:devfrom
bdraco:aid_storage_avoid_entity_id_collisions
Apr 23, 2020
Merged

Remember homekit aids for entities without a unique id#34587
bdraco merged 3 commits intohome-assistant:devfrom
bdraco:aid_storage_avoid_entity_id_collisions

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 23, 2020 •
edited
Loading

Proposed change

Remember homekit aids for entities without a unique id

Addresses #34562 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco added this to the 0.109.0 milestone Apr 23, 2020
@bdraco bdraco requested a review from Jc2k April 23, 2020 14:52
@Jc2k
Copy link
Copy Markdown
Member

Jc2k commented Apr 23, 2020

Ah, my expectation was only "old" crufty integrations wouldn't set unique_id these days, bummer. Seems like a reasonable change 👍

frenck
frenck approved these changes Apr 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@bdraco bdraco merged commit a7e8446 into home-assistant:dev Apr 23, 2020
@bdraco bdraco mentioned this pull request Apr 23, 2020
Merged
20 tasks
balloob pushed a commit that referenced this pull request Apr 23, 2020
@bdraco @balloob
Remember homekit aids for entities without a unique id (#34587)
dd63225 
* Remember homekit aids for entities without a unique id

* add backwards compat

* increase cover
@lock lock Bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@frenck frenck frenck approved these changes

@Jc2k Jc2k Awaiting requested review from Jc2k

Assignees

No one assigned

Labels

by-code-owner cherry-picked cla-signed has-tests integration: homekit small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.109.0

Development

Successfully merging this pull request may close these issues.

Problem with missing unique identifier in Homekit

5 participants

@bdraco @Jc2k @frenck @balloob @homeassistant