Skip to content

Powerwall sensor add is_active, round state attributes and change thresholding for charging status sensor#34582

Merged
bdraco merged 2 commits intohome-assistant:devfrom
jrester:powerwall_update
Apr 23, 2020
Merged

Powerwall sensor add is_active, round state attributes and change thresholding for charging status sensor#34582
bdraco merged 2 commits intohome-assistant:devfrom
jrester:powerwall_update

Conversation

@jrester
Copy link
Copy Markdown
Contributor

@jrester jrester commented Apr 23, 2020 •
edited by bdraco
Loading

Proposed change

  • Add is_active to Meter sensor
  • Round device_state_attributes of Meter sensor
  • Use is_sending_to for PowerWallChargingStatusSensor so it behaves the same way as in the web UI

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented Apr 23, 2020

Hey there @bdraco, mind taking a look at this pull request as its been labeled with a integration (powerwall) you are listed as a codeowner for? Thanks!

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 23, 2020

@jrester Noticed that the margin of error was too low yesterday. 100w seems a lot but it seems right. Nice fix and cleanup 👍

@bdraco bdraco added this to the 0.109.0 milestone Apr 23, 2020
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 23, 2020

Screen Shot 2020-04-23 at 9 59 35 AM

Should fixed the phantom "charging" in the middle of the night ;)

bdraco
bdraco approved these changes Apr 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed working as expected

@bdraco bdraco merged commit 4a5cf5c into home-assistant:dev Apr 23, 2020
balloob pushed a commit that referenced this pull request Apr 23, 2020
@jrester @balloob
Powerwall sensor add is_active, round state attributes and change thr…
7c54cd5 
…esholding for charging status sensor (#34582)

* Change sensor values and thresholding

* Update tests
@lock lock Bot locked and limited conversation to collaborators Apr 25, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

@bdraco bdraco

Labels

bugfix by-code-owner cherry-picked cla-signed code-quality has-tests integration: powerwall small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

0.109.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jrester @bdraco @balloob @homeassistant