Split iRobot Braava "fan_speed" into seperate options#34569
Conversation
|
@shenxn https://github.com/home-assistant/architecture/issues/new Would you please open an architecture issue for the change to the vacuum as it needs to be reviewed and approved before this can move forward |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
I'll convert this to draft since it's waiting on an architecture issue. Is it possible to split this PR so everything isn't blocked by the architecture issue, or is that not possible? |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Braava support was added in #33616. Currently the mop behavior and spray amount are set together through

fan_speed. This PR split them into individual options by addSUPPORT_OPTIONfeature andset_optionservice to thevacuumcomponent.Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Front end PR: #5596
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: