Skip to content

Split iRobot Braava "fan_speed" into seperate options#34569

Closed
shenxn wants to merge 3 commits into
home-assistant:devfrom
shenxn:vacuum-options
Closed

Split iRobot Braava "fan_speed" into seperate options#34569
shenxn wants to merge 3 commits into
home-assistant:devfrom
shenxn:vacuum-options

Conversation

@shenxn
Copy link
Copy Markdown
Contributor

@shenxn shenxn commented Apr 23, 2020

Proposed change

Braava support was added in #33616. Currently the mop behavior and spray amount are set together through fan_speed. This PR split them into individual options by add SUPPORT_OPTION feature and set_option service to the vacuum component.
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Front end PR: #5596

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @pschmitt, @cyr-ius, mind taking a look at this pull request as its been labeled with a integration (roomba) you are listed as a codeowner for? Thanks!

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 23, 2020

@shenxn https://github.com/home-assistant/architecture/issues/new Would you please open an architecture issue for the change to the vacuum as it needs to be reviewed and approved before this can move forward

@shenxn
Copy link
Copy Markdown
Contributor Author

shenxn commented Apr 23, 2020

@bdraco Done. #371

@bdraco bdraco self-requested a review April 24, 2020 15:13
@stale
Copy link
Copy Markdown

stale Bot commented Jun 3, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale Bot added the stale label Jun 3, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

I'll convert this to draft since it's waiting on an architecture issue.

Is it possible to split this PR so everything isn't blocked by the architecture issue, or is that not possible?

@MartinHjelmare MartinHjelmare marked this pull request as draft June 8, 2020 19:44
@stale stale Bot removed the stale label Jun 8, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Jul 11, 2020

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale Bot added the stale label Jul 11, 2020
@stale stale Bot closed this Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants