Bump python-synology to 0.7.0#34534
Merged
bdraco merged 1 commit intohome-assistant:devfrom Apr 22, 2020
Merged
Conversation
|
Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration ( |
e764c86 to
4c5936e
Compare
4c5936e to
9d24e67
Compare
Member
Author
Tested on DSM 6
Everything is fine 👌 🎉 |
Merged
8 tasks
Member
Author
|
Just removed the |
Member
|
Will test later today when things are less busy |
Member
Author
|
I hoped for a 0.109.0 to avoid an other breaking change on 0.110.0, but sure time is short now 😬 |
Member
|
@Quentame Did light testing and everything appears to be working. I don't have a v5 box anymore so I can only verify v6 |
Member
|
Tested with two different boxes. No issues |
bdraco
approved these changes
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Remove
api_versionconfig paramProposed change
Bump python-synology to 0.7.0
https://github.com/ProtoThis/python-synology/releases/tag/0.7.0
It adds API discovery + DSM version dicovery + uses Exceptions instead of catching everything and returning None.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: