Skip to content

Don't set step title if it's integration title#34524

Merged
frenck merged 1 commit intodevfrom
optional-step-title
Apr 22, 2020
Merged

Don't set step title if it's integration title#34524
frenck merged 1 commit intodevfrom
optional-step-title

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 22, 2020

Breaking change

Proposed change

Config flow steps without a title will fallback to the integration title once home-assistant/frontend#5584 is merged. This allows us to clean up a bunch of translations.

Part of #34264
Requires home-assistant/frontend#5584

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob mentioned this pull request Apr 22, 2020
44 tasks
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The frontend is merged into the core repo.

@frenck frenck merged commit e002c84 into dev Apr 22, 2020
@frenck frenck deleted the optional-step-title branch April 22, 2020 13:05
@lock lock Bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants