Conversation
Contributor
|
just wonder would api_key be a common data string as well? |
Member
Author
|
Yeah, and access token. Really anything that would ever be shared by more than 1 integration should be added. |
7b77997 to
5e28ade
Compare
MartinHjelmare
approved these changes
May 5, 2020
balloob
commented
May 5, 2020
| """Migrate translations.""" | ||
| # Import new common keys | ||
| migrate_project_keys_translations( | ||
| rename_keys( |
Member
Author
There was a problem hiding this comment.
What's happening here is that we one-time rename these keys to the common keys. Then when strings are uploaded after merge, the old names are created again, but their new value is set up as a reference to the new name.
Member
Author
There was a problem hiding this comment.
So this script needs to run before merge.
Member
Author
There was a problem hiding this comment.
Yes, I will do that once CI passses.
ctalkington
reviewed
May 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Adds common config flow strings.
Go through existingFor follow-up PRstrings.jsonand use referencesAdd hassfest check to find strings that can use referencesFor follow-up PRTesting to do:
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: