Skip to content

Rename BinarySensorDevice to BinarySensorEntity#34462

Merged
MartinHjelmare merged 6 commits intohome-assistant:devfrom
emontnemery:binarysensorentity
Apr 23, 2020
Merged

Rename BinarySensorDevice to BinarySensorEntity#34462
MartinHjelmare merged 6 commits intohome-assistant:devfrom
emontnemery:binarysensorentity

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Apr 20, 2020

Proposed change

Rename BinarySensorDevice to BinarySensorEntity.

Keep BinarySensorDevice to not break custom components, but print a warning when it's instantiated.

PRs for other base components will be opened based on the feedback on this one.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good!

Let's hold a bit on merging to get some more thoughts.

Comment thread homeassistant/components/binary_sensor/__init__.py Outdated
Comment thread homeassistant/components/binary_sensor/__init__.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit b022e08 into home-assistant:dev Apr 23, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 25, 2020
@emontnemery emontnemery deleted the binarysensorentity branch June 10, 2020 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants