Rename BinarySensorDevice to BinarySensorEntity#34462
Merged
MartinHjelmare merged 6 commits intohome-assistant:devfrom Apr 23, 2020
Merged
Rename BinarySensorDevice to BinarySensorEntity#34462MartinHjelmare merged 6 commits intohome-assistant:devfrom
MartinHjelmare merged 6 commits intohome-assistant:devfrom
Conversation
MartinHjelmare
approved these changes
Apr 20, 2020
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
I think this is good!
Let's hold a bit on merging to get some more thoughts.
MartinHjelmare
approved these changes
Apr 22, 2020
This was referenced Apr 23, 2020
This was referenced Apr 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Rename BinarySensorDevice to BinarySensorEntity.
Keep BinarySensorDevice to not break custom components, but print a warning when it's instantiated.
PRs for other base components will be opened based on the feedback on this one.
Type of change
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.