Skip to content

Fix proliphix#34397

Merged
MartinHjelmare merged 5 commits into
home-assistant:devfrom
mhorst314:fix-proliphix
May 2, 2020
Merged

Fix proliphix#34397
MartinHjelmare merged 5 commits into
home-assistant:devfrom
mhorst314:fix-proliphix

Conversation

@mhorst314
Copy link
Copy Markdown
Contributor

@mhorst314 mhorst314 commented Apr 18, 2020

Proposed change

This pull request fixes the problem that the proliphix component will not start (with the error KeyError: 'DevName'), as described in #34396.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @mhorst314,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Comment thread homeassistant/components/proliphix/climate.py
Comment thread homeassistant/components/proliphix/climate.py
@MartinHjelmare
Copy link
Copy Markdown
Member

Please run black and isort from the project root to fix the build checks.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 2f31b85 into home-assistant:dev May 2, 2020
@balloob balloob added the bugfix label May 4, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proliphix component fails to start with KeyError: 'DevName'

5 participants