Skip to content

Restore isy light brightness after off#34320

Merged
balloob merged 1 commit intohome-assistant:devfrom
bdraco:isy994_restore_brightness_off_on
Apr 17, 2020
Merged

Restore isy light brightness after off#34320
balloob merged 1 commit intohome-assistant:devfrom
bdraco:isy994_restore_brightness_off_on

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 16, 2020

Proposed change

ISY forget the brightness when turning on an off a light. I had assumed this was expected behavior but learned otherwise here (#34299 (comment))

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 16, 2020

Before

isy_forgets_brightness

After

isy_brightness_memory

@balloob balloob merged commit b9e882f into home-assistant:dev Apr 17, 2020
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 17, 2020

TYVM

@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants