Skip to content

Update pyhomematic to 0.1.66#34314

Merged
balloob merged 2 commits intohome-assistant:devfrom
danielperna84:dev
Apr 16, 2020
Merged

Update pyhomematic to 0.1.66#34314
balloob merged 2 commits intohome-assistant:devfrom
danielperna84:dev

Conversation

@danielperna84
Copy link
Copy Markdown
Contributor

@danielperna84 danielperna84 commented Apr 16, 2020

Proposed change

  • Adds support for new devices
  • Gets rid of some warnings in the logs
  • Minor improvement for HmIP Thermostats
  • Add channel to service in services.yaml to make clear it's ok to use channels there

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @pvizeli, mind taking a look at this pull request as its been labeled with a integration (homematic) you are listed as a codeowner for? Thanks!

@danielperna84
Copy link
Copy Markdown
Contributor Author

Sorry for including the services.yaml tweak in this PR. But it's just too minor to justify a separate PR I guess. 👼

@danielperna84 danielperna84 changed the title Update pyhomematic to 0.1.65 Update pyhomematic to 0.1.66 Apr 16, 2020
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balloob balloob merged commit f757ca6 into home-assistant:dev Apr 16, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
@balloob balloob added the dependency Pull requests marked as a dependency upgrade label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed dependency Pull requests marked as a dependency upgrade integration: homematic small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HmIP-BROLL WORKING value unrecognized

5 participants