Skip to content

Fix uncaught exception in local_file#34312

Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom
ziv1234:fix24
Apr 17, 2020
Merged

Fix uncaught exception in local_file#34312
MartinHjelmare merged 3 commits intohome-assistant:devfrom
ziv1234:fix24

Conversation

@ziv1234
Copy link
Copy Markdown
Contributor

@ziv1234 ziv1234 commented Apr 16, 2020

Breaking change

Proposed change

Fixes the uncaught exception in local_file
since this is the last remaining uncaught exception, removed the temporary infrastructure that ignores exceptions from the list

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added core small-pr PRs with less than 30 lines. labels Apr 16, 2020
@ziv1234 ziv1234 changed the title not yet ready - remove uncaught exceptions in localfile Fix uncaught exception in local_file Apr 16, 2020
@MartinHjelmare
Copy link
Copy Markdown
Member

Great!

@MartinHjelmare MartinHjelmare merged commit 1259979 into home-assistant:dev Apr 17, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix local_file tests that have uncaught exceptions

3 participants