Fix default elkm1 temp units#34274
Merged
balloob merged 4 commits intohome-assistant:devfrom Apr 16, 2020
Merged
Conversation
The default units was "F" but the value needed to be "°F"
Member
Author
|
Should be tagged for 0.108.6 if we do one |
balloob
approved these changes
Apr 16, 2020
| config = {"temperature_unit": conf[CONF_TEMPERATURE_UNIT]} | ||
| temperature_unit = TEMP_FAHRENHEIT | ||
| if conf[CONF_TEMPERATURE_UNIT] in (BARE_TEMP_CELSIUS, TEMP_CELSIUS): | ||
| temperature_unit = TEMP_CELSIUS |
Member
There was a problem hiding this comment.
It's better to implement a config entry migration handler to update the config entry data to the correct state before the integration is set up.
See eg:
core/homeassistant/components/huawei_lte/__init__.py
Lines 541 to 551 in d672eed
Member
Author
There was a problem hiding this comment.
Thanks. Will look at cleaning this up once everything settles a bit more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The yaml config uses
cv.temperature_unitwhich mutates "F" -> "°F". The config flow conversion didn't contemplate that. We need the units in "°F" format for the config flow.The default unit was "F" but the value needed to be "°F"
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: